Make Config.Timeout functional and expose as --timeout flag#63
Merged
Conversation
The Timeout field existed in Config but was never used. httpClient() hardcoded 30 * time.Second. Now httpClient() reads from i.Timeout, and a new --timeout persistent flag (default 30s) is exposed on the root command. Also configurable via IMS_TIMEOUT env var or config file.
andresbott
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the unused Timeout field functional
The
Timeoutfield existed in theConfigstruct but was dead code —httpClient()hardcoded30 * time.Secondand no command exposed it as a flag.Now:
httpClient()usestime.Duration(i.Timeout) * time.Secondinstead of the hardcoded value--timeoutpersistent flag (default 30 seconds) is exposed on the root commandIMS_TIMEOUTenv var or config file